Skip to content
This repository has been archived by the owner on Jan 5, 2019. It is now read-only.

Retire wabt #174

Closed
wants to merge 1 commit into from
Closed

Retire wabt #174

wants to merge 1 commit into from

Conversation

axic
Copy link
Member

@axic axic commented Jan 24, 2018 •
edited
Loading

Depends on #173 and ewasm/wast2wasm#11.

@axic
Copy link
Member Author

axic commented Jan 24, 2018

Need to be rebased after #173 is merged.

@axic axic mentioned this pull request Jan 27, 2018
Merged
@axic axic force-pushed the retire-wabt branch 2 times, most recently from 7292b82 to aeb6b35 Compare March 26, 2018 20:36
@cdetrio cdetrio mentioned this pull request Apr 2, 2018
Open
@axic
Copy link
Member Author

axic commented Apr 9, 2018

This currently is failing on one test:

# manyFunctions100 manyFunctions100
not ok 1425 RangeError: Maximum call stack size exceeded
  ---
    operator: fail
    at: runner.catch.err (/home/travis/build/ewasm/evm2wasm/tests/runVmTests.js:171:9)
    stack: |-
      Error: RangeError: Maximum call stack size exceeded
          at Test.assert [as _assert] (/home/travis/build/ewasm/evm2wasm/node_modules/tape/lib/test.js:225:54)
          at Test.bound [as _assert] (/home/travis/build/ewasm/evm2wasm/node_modules/tape/lib/test.js:77:32)
          at Test.fail (/home/travis/build/ewasm/evm2wasm/node_modules/tape/lib/test.js:318:10)
          at Test.bound [as fail] (/home/travis/build/ewasm/evm2wasm/node_modules/tape/lib/test.js:77:32)
          at runner.catch.err (/home/travis/build/ewasm/evm2wasm/tests/runVmTests.js:171:9)
          at <anonymous>
          at process._tickCallback (internal/process/next_tick.js:188:7)
  ...

I think this actually is happening inside the emscripten-ized wabt. If that is the case the only chance here is to update wabt and/or recompile it with different emscripten flags.

However, in the long term a better solution would be fixing ewasm/wasm-json-toolkit#19

Lastly, none of this is important if we're moving evm2wasm to C++.

@lrettig
Copy link
Member

lrettig commented May 25, 2018

Closing in favor of #249

@lrettig lrettig closed this May 25, 2018
@axic axic deleted the retire-wabt branch May 25, 2018 22:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axic @lrettig